Skip to content

fix: Throw error for unknown command #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 2 commits into from
May 20, 2017
+1 −0
Merged

fix: Throw error for unknown command #14

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e189bab
fix: Throw error for unknown command
rkostrzewski May 20, 2017
b363c8c
fix: Throw error for unknown command - keep preact test script
rkostrzewski May 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export default asyncCommand({
build: 'preact build',
serve: 'preact build && preact serve',
dev: 'preact watch',
test: 'eslint src && preact test'
test: 'eslint src && echo "Error: no test specified" && exit 1'
Copy link
Member

@developit developit May 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one we actually probably need to keep as preact test - that command isn't available yet, but it will just spawn a preconfigured jest. I wanted to get the setup into generated package.json's since we can't retroactively update them later.

Would you be all right removing this one line? I think we can get the test command released really soon.

Copy link
Collaborator Author

@rkostrzewski rkostrzewski May 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be preact test? ❤️

};

pkg.eslintConfig = {
Expand Down
1 change: 1 addition & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ yargs
.help()
.alias('h', 'help')
.demandCommand()
.strict()
.argv;