Fix/sw src #1618
Merged
Fix/sw src #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cfb62a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
fix/sw-src
branch
from
c982ed4 to
0e0d687
Compare
rschristian
commented
Nov 19, 2021
| "style-loader": "^2.0.0", | ||
| "terser-webpack-plugin": "^4.2.3", | ||
| "typescript": "^4.2.4", | ||
| "typescript": "~4.2.4", |
Member
Author
There was a problem hiding this comment.
This is completely unrelated. I could move into a separate PR if desired.
From what I understand, Yarn needs to manually patch some dependencies like TS on every release. TS 4.5 just came out, which apparently caused some issues in the PnP pipeline.
Restricting this to a patch/TS minor should be fine I believe, and works around PnP breakages in the future.
Member
There was a problem hiding this comment.
eh, if it makes CI pass leave it in.
developit
approved these changes
Nov 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Did you add tests for your changes?
No
Summary
With ESM disabled,
InjectManifestusedjoin(src, sw.js)to get the service worker path. If this did not exist (if the user [re]moved the file), the build would error out.We already had a system set up to catch this and fall back to the one provided from
preact-cli, just weren't using it on non-esm builds.Does this PR introduce a breaking change?
No