Skip to content

Fix/sw src #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForsakenHarmony merged 3 commits into from
Nov 19, 2021
Merged

Fix/sw src #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1291e4
fix: Error when `src/sw.js` does not exist w/ esm disabled
rschristian Nov 19, 2021
0e0d687
docs: Adding changeset
rschristian Nov 19, 2021
cfb62a3
fix: Yarn PnP issues
rschristian Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sixty-badgers-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-cli': patch
---

Corrects error when `src/sw.js` does not exist and esm is disabled
2 changes: 1 addition & 1 deletion packages/cli/lib/lib/webpack/webpack-client-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ async function clientConfig(env) {
]
: [
new InjectManifest({
swSrc: join(src, 'sw.js'),
swSrc: swPath,
include: [
/200\.html$/,
/\.js$/,
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
"stack-trace": "0.0.10",
"style-loader": "^2.0.0",
"terser-webpack-plugin": "^4.2.3",
"typescript": "^4.2.4",
"typescript": "~4.2.4",
Copy link
Member Author

@rschristian rschristian Nov 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is completely unrelated. I could move into a separate PR if desired.

From what I understand, Yarn needs to manually patch some dependencies like TS on every release. TS 4.5 just came out, which apparently caused some issues in the PnP pipeline.

Restricting this to a patch/TS minor should be fine I believe, and works around PnP breakages in the future.

Copy link
Member

@developit developit Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, if it makes CI pass leave it in.

"update-notifier": "^5.1.0",
"url-loader": "^4.1.1",
"validate-npm-package-name": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14431,7 +14431,7 @@ typedarray@^0.0.6:
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=

typescript@^4.2.4:
typescript@~4.2.4:
version "4.2.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.2.4.tgz#8610b59747de028fda898a8aef0e103f156d0961"
integrity sha512-V+evlYHZnQkaz8TRBuxTA92yZBPotr5H+WhQ7bD3hZUndx5tGOa1fuCgeSjxAzM1RiN5IzvadIXTVefuuwZCRg==
Expand Down