Skip to content

removed boolean check for running dev server in https #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkostrzewski merged 3 commits into from
Jul 3, 2017
Merged

removed boolean check for running dev server in https #176

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2985eb3
removed boolean check for running dev server in https
reznord Jul 3, 2017
a4f71a1
remove alias for host in watch command
reznord Jul 3, 2017
9db788e
Revert "remove alias for host in watch command"
reznord Jul 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/commands/watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ export default asyncCommand({
},
host: {
description: 'Hostname to start a server on',
default: '0.0.0.0',
alias: 'h'
Copy link
Member Author

@reznord reznord Jul 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the alias for the host command since this is colliding with yargs package's --help, -h.

Copy link
Member Author

@reznord reznord Jul 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is supposed to be a separate PR, but since already a PR is in queue, it just appended !!

Sorry for the mess 😅

Copy link
Collaborator

@thangngoc89 thangngoc89 Jul 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to a seperate PR as your PR could be squashed to create a clean git history.

default: '0.0.0.0'
},
https: {
description: 'Use HTTPS?',
Expand Down
2 changes: 1 addition & 1 deletion src/lib/webpack/webpack-client-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const development = config => {
host,
inline: true,
hot: true,
https: config.https===true,
https: config.https,
compress: true,
publicPath: '/',
contentBase: resolve(config.cwd, config.src || './src'),
Expand Down