removed boolean check for running dev server in https #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reznord
commented
Jul 3, 2017
| host: { | ||
| description: 'Hostname to start a server on', | ||
| default: '0.0.0.0', | ||
| alias: 'h' |
Member
Author
There was a problem hiding this comment.
removing the alias for the host command since this is colliding with yargs package's --help, -h.
Member
Author
There was a problem hiding this comment.
and this is supposed to be a separate PR, but since already a PR is in queue, it just appended !!
Sorry for the mess 😅
Collaborator
There was a problem hiding this comment.
Please move this to a seperate PR as your PR could be squashed to create a clean git history.
This reverts commit a4f71a1.
rkostrzewski
approved these changes
Jul 3, 2017
Collaborator
rkostrzewski
left a comment
rkostrzewski
left a comment
There was a problem hiding this comment.
Looking good 👍 Additional benefit - we'll be using same cert for preact serve and preact watch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed boolean check for running dev server in https from here
Now you can run dev server in
HTTPSFix for bug #175