Adds update-notifier #361
Merged
Adds update-notifier #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Don't know how to test it locally lol 😛 Hoping that it will work 😅 |
lukeed
requested changes
Sep 8, 2017
src/index.js
Outdated
| import pkg from '../package.json'; | ||
| import logo from './lib/logo'; | ||
| import checkVersion from './../check'; | ||
| import updateNotifier from 'update-notifier'; |
Member
There was a problem hiding this comment.
Let's move this to line 2, so that it precedes all the local imports.
Member
Author
There was a problem hiding this comment.
Done. Didn't think about this earlier.
src/index.js
Outdated
| .strict() | ||
| .argv; | ||
|
|
||
| updateNotifier({pkg}).notify({ defer: true }); |
Member
There was a problem hiding this comment.
This should be before all the yargs(...) stuff takes place -- aka, right after the checkVersion().
Also, we don't need defer:true --- it's true by default.
lukeed
requested changes
Sep 8, 2017
src/index.js
Outdated
|
|
||
| installHooks(); | ||
|
|
||
| updateNotifier({pkg}).notify({ defer: true }); |
Member
There was a problem hiding this comment.
Can remove defer:true because it is already the default. 👍
lukeed
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds update notifier to the CLI and reminds the user on every CLI command her runs.
/cc @developit