Skip to content

Adds update-notifier #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukeed merged 3 commits into from
Sep 8, 2017
Merged

Adds update-notifier #361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
073db68
Adds update-notifier
reznord Sep 7, 2017
7f5a6d5
Move updater.notify() before yargs
reznord Sep 8, 2017
140bb78
Remove defer
reznord Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@
"sw-precache-webpack-plugin": "^0.11.2",
"tmp": "0.0.31",
"unfetch": "^3.0.0",
"update-notifier": "^2.2.0",
"url-loader": "^0.5.8",
"webpack": "^2.3.3",
"webpack-chunk-hash": "^0.4.0",
Expand Down
3 changes: 3 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import installHooks from './lib/output-hooks';
import pkg from '../package.json';
import logo from './lib/logo';
import checkVersion from './../check';
import updateNotifier from 'update-notifier';
Copy link
Member

@lukeed lukeed Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to line 2, so that it precedes all the local imports.

Copy link
Member Author

@reznord reznord Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Didn't think about this earlier.


global.Promise = require('bluebird');

Expand All @@ -31,3 +32,5 @@ yargs
.demandCommand()
.strict()
.argv;

updateNotifier({pkg}).notify({ defer: true });
Copy link
Member

@lukeed lukeed Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be before all the yargs(...) stuff takes place -- aka, right after the checkVersion().

Also, we don't need defer:true --- it's true by default.

Copy link
Member Author

@reznord reznord Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7288,7 +7288,7 @@ update-notifier@^1.0.3:
semver-diff "^2.0.0"
xdg-basedir "^2.0.0"

update-notifier@^2.1.0:
update-notifier@^2.1.0, update-notifier@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/update-notifier/-/update-notifier-2.2.0.tgz#1b5837cf90c0736d88627732b661c138f86de72f"
dependencies:
Expand Down