hmr fix #417
Merged
hmr fix #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reznord
approved these changes
Oct 21, 2017
| }; | ||
|
|
||
| if (!isProd) { | ||
| entry['hmr'] = `webpack-dev-server/client?http://localhost:${process.env.PORT || env.port || 8080}`; |
Member
There was a problem hiding this comment.
This is a temporary fix with with we can go for now. But I guess the HMR failure is related to webpack-dev-server or html-webpack-plugin.
Once it is fixed in the upstream, we can clean this off.
developit
approved these changes
Oct 21, 2017
Member
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
Any chance the port change is unnecessary here?
Member
Author
|
@developit the port in here has to exactly be your devServer port option otherwise you'll get console messages that socket can't connect, therefore no hmr. |
Member
|
Thank you so much for fixing this! We definitely tort this upstream in case someone hasn't already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a little preact-cli project I work with on weekends.
Today HMR stopped working and I am able to get it to work back via this fix.
dev-server was not emitting socket-js with the dev bundle and seems like the combo of Webpack HMR plugin +
hot:truein dev-server options is not working.This fix will ensure in Dev mode, the required socket stuff are committed to
hmrbundle and the reload happens.is there better ideas? happy to discuss.