Adds a Pull Request tempalte for CLI #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekbh
requested changes
Jan 2, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| <!-- E.g. a bugfix, feature, refactoring, build related change, etc… --> | ||
|
|
||
| **If relevant, did you add tests for your changes?** |
Member
Author
There was a problem hiding this comment.
true, changed in the latest commit.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| **If relevant, did you add tests for your changes?** | ||
|
|
||
|
|
||
| **If relevant, link to documentation update:** |
Member
There was a problem hiding this comment.
not sure how many times'll really get this
Member
Author
There was a problem hiding this comment.
oh right! we only have one documentation. this is not a valid one (removed)
| **If this is a feature request, what is motivation or use case for changing the behavior?** | ||
| **If this is a feature request, what is motivation or use case for changing the behaviour?** | ||
|
|
||
| **Please mention other relevant information.** |
Member
There was a problem hiding this comment.
can we add browser name and version?
Member
Author
There was a problem hiding this comment.
added it in the comment below.
developit
approved these changes
Jan 10, 2018
prateekbh
approved these changes
Jan 10, 2018
Member
Author
|
Wondering how come it is open for over a week 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default template for Pull Requests (which we had one before for Issues)