Skip to content

Adds a Pull Request tempalte for CLI #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reznord merged 3 commits into from
Jan 10, 2018
Merged

Adds a Pull Request tempalte for CLI #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dd11b3
Adds a Pull Request tempalte for CLI
reznord Jan 1, 2018
66d138b
remove documentation link
reznord Jan 4, 2018
37fc0d0
Add CLI version, browsers to issue_template
reznord Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

**What kind of change does this PR introduce?**

<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

**Did you add tests for your changes?**


**Summary**

<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
<!-- Try to link to an open issue for more information. -->

**Does this PR introduce a breaking change?**

<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

**Other information**

<!-- Node version, npm version, CLI version, operating system, browser -->
12 changes: 7 additions & 5 deletions .github/issue_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,19 @@

**Do you want to request a *feature* or report a *bug*?**

**What is the current behavior?**
**What is the current behaviour?**

**If the current behavior is a bug, please provide the steps to reproduce.**
**If the current behaviour is a bug, please provide the steps to reproduce.**

<!-- A great way to do this is to provide your configuration via a GitHub gist. -->

**What is the expected behavior?**
**What is the expected behaviour?**

**If this is a feature request, what is motivation or use case for changing the behavior?**
**If this is a feature request, what is motivation or use case for changing the behaviour?**

**Please mention other relevant information.**
Copy link
Member

@prateekbh prateekbh Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add browser name and version?

Copy link
Member Author

@reznord reznord Jan 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added it in the comment below.

- node version
- Node version
- npm version
- Operating system
- CLI version
- Browser