Fix: Async component loader wrong path for 'async!...' imports #50
Conversation
src/lib/async-component-loader.js
Outdated
| var routeName = typeof query.name === 'function' ? query.name(this.resourcePath) : null; | ||
| var name = routeName !== null ? routeName : ('name' in query ? query.name : (query.formatName || String)(this.resourcePath)); | ||
| var name | ||
| if(routeName !== null) { |
There was a problem hiding this comment.
Nitpick: missing space after if keyword
| "no-console": 1, | ||
| "no-empty": 0, | ||
| "semi": 2, | ||
| "keyword-spacing": 2, |
There was a problem hiding this comment.
@developit I took the liberty of adding those rules to eslint - please check if they're ok with you.
Semicolons are enforced (they were placed almost everywhere and not enforced) & spaces should be placed after keyword (no changes to files).
There was a problem hiding this comment.
both good with me, thanks a bunch!
| this.cacheable && this.cacheable(); | ||
| var query = loaderUtils.getOptions(this) || {}; | ||
| var routeName = typeof query.name === 'function' ? query.name(this.resourcePath) : null; | ||
| var name = routeName !== null ? routeName : ('name' in query ? query.name : (query.formatName || String)(this.resourcePath)); |
There was a problem hiding this comment.
I knew someone would undo this lovely upsetting ternary
|
Are you able to shed light on what was messed up here? I'm happy to merge the change, just curious if it was a logic error or something I'm not seeing. |
|
Previously this.resourcePath (which is an absolute URI) was passed to require.ensure third param which is chunk name - this in turn led to chunk names having whole absolute path as name ^^. |
3 participants
Fixes #47