Skip to content

Fix: Async component loader wrong path for 'async!...' imports #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 5 commits into from
May 25, 2017
Merged

Fix: Async component loader wrong path for 'async!...' imports #50

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cad989d
Merge branch 'developit/master'
rkostrzewski May 20, 2017
af49e27
Merge branch 'developit/master'
rkostrzewski May 21, 2017
a2e5929
fix: wrong build path for 'async!' imports. Fixes #47
rkostrzewski May 23, 2017
2259f4a
fix: Incorrect async-component-loader refactor
rkostrzewski May 23, 2017
e2cad10
chore: Configure eslint & fix linting errors
rkostrzewski May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/lib/async-component-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ module.exports.pitch = function(remainingRequest) {
this.cacheable && this.cacheable();
var query = loaderUtils.getOptions(this) || {};
var routeName = typeof query.name === 'function' ? query.name(this.resourcePath) : null;
var name = routeName !== null ? routeName : ('name' in query ? query.name : (query.formatName || String)(this.resourcePath));
Copy link
Member

@developit developit May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew someone would undo this lovely upsetting ternary

var name
if(routeName !== null) {
Copy link
Member

@marvinhagemeister marvinhagemeister May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: missing space after if keyword

name = routeName
} else if ('name' in query) {
name = query.name
} else if ('formatName' in query) {
name = query.formatName(this.resourcePath)
}

return `
import async from ${JSON.stringify(path.resolve(__dirname, '../components/async'))};
Expand Down