fix: Incorrect dev server address in console #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeed
requested changes
May 24, 2017
Member
There was a problem hiding this comment.
I was about to PR this too 😄 Our fearless @developit prefers let tho -- mind quick fixing?
Collaborator
Author
|
Why tho? Bet it is 2x faster, or generated JS is smaller 😆 |
lukeed
approved these changes
May 24, 2017
Member
lukeed
left a comment
lukeed
left a comment
There was a problem hiding this comment.
Is just his preference, we like to bug him about it 😜
But "easier to write" and "const for globals" are what's usually tossed around. Makes sense~
Thanks!
Member
|
|
Member
|
I didn't comment on the commit message because I wanted to give you the joy and surprise of discovering it lol. 11/10, well played sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
I should probably stop spamming with those PRs 😅