Skip to content

fix: Incorrect dev server address in console #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 5 commits into from
May 25, 2017
Merged

fix: Incorrect dev server address in console #57

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cad989d
Merge branch 'developit/master'
rkostrzewski May 20, 2017
af49e27
Merge branch 'developit/master'
rkostrzewski May 21, 2017
a4ce32b
Merge branch 'developit/master'
rkostrzewski May 23, 2017
47e05ac
fix: Incorrect address displayed for dev server
rkostrzewski May 24, 2017
41b3795
refactor: let const go
rkostrzewski May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/run-webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export default (watch=false, config, onprogress) => new Promise( (resolve, rejec
compiler.plugin('done', stats => {
if (first) {
first = false;
let serverAddr = `${config.https===true?'https':'http'}://${process.env.HOST || config.host || 'localhost'}:${process.env.PORT || config.port || 8080}`;
const devServer = config.devServer
const serverAddr = `${devServer.https===true?'https':'http'}://${process.env.HOST || devServer.host || 'localhost'}:${process.env.PORT || devServer.port || 8080}`;
process.stdout.write(` \u001b[32m> Development server started at ${serverAddr}\u001b[39m\n`);
}
if (onprogress) onprogress(stats);
Expand Down