Respect browserslist configurations #829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
No, this does not add tests, and there were no browserslist tests previously. Also, adding breaking browserslist configurations for the current release would only be useful if this project continues to manually check for configurations, which this change removes. Also, testing browserslist configurations could be problematic, as browserslist-enabled tooling within Babel and PostCSS would frequently change output as polyfills are updated and global usage stats change.
Summary
I looked into this codebase to see why our
.browserslistrcfile was not being respected.I saw the excellent work in #125 and decided to bring it that effort further into alignment with browserslist with this PR.
Does this PR introduce a breaking change?
No, this does not introduce a breaking change.
Other information
This adds a
browserslistdependency, but it should de-dupe along with the other nestedbrowserslistdependencies. See these results fornom ls browserslist: