Skip to content

Respect browserslist configurations #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prateekbh merged 1 commit into from
Jul 10, 2019
Merged

Respect browserslist configurations #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/cli/lib/lib/webpack/webpack-base-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const { resolve } = require('path');
const { readFileSync, existsSync } = require('fs');
const SizePlugin = require('size-plugin');
const autoprefixer = require('autoprefixer');
const browserslist = require('browserslist');
const requireRelative = require('require-relative');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const FixStyleOnlyEntriesPlugin = require('webpack-fix-style-only-entries');
Expand Down Expand Up @@ -64,7 +65,15 @@ module.exports = function(env) {
env.pkg = readJson(resolve(cwd, 'package.json')) || {};

let babelrc = readJson(resolve(cwd, 'old')) || {};
let browsers = env.pkg.browserslist || ['> 0.25%', 'IE >= 9'];

// use browserslist config environment, config default, or default browsers
// default browsers are > 0.25% global market share or Internet Explorer >= 9
const browserslistDefaults = ['> 0.25%', 'IE >= 9'];
const browserlistConfig = Object(browserslist.findConfig(cwd));
const browsers =
(isProd ? browserlistConfig.production : browserlistConfig.development) ||
browserlistConfig.default ||
browserslistDefaults;

let userNodeModules = findAllNodeModules(cwd);
let cliNodeModules = findAllNodeModules(__dirname);
Expand Down
1 change: 1 addition & 0 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
"babel-plugin-macros": "^2.5.1",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"brotli-webpack-plugin": "^1.0.0",
"browserslist": "^4.6.4",
"console-clear": "^1.0.0",
"copy-webpack-plugin": "^5.0.3",
"critters-webpack-plugin": "^1.3.3",
Expand Down