feat(skore-hub-project): Reduce `put` time by thomass-dev · Pull Request #2114 · probabl-ai/skore

thomass-dev · 2025-10-30T15:20:21Z

Partially addresses #2140:

Use the hash generated by skore to upload a report
Thread the compute of report media
- All media are computed in "parallel", divided in chunk of ~10mb and sent to the upload queue
- The upload queue is emptied in "parallel" 6 chunks of 6, to avoid flooding the hub

github-actions · 2025-11-26T16:16:18Z

Coverage Report for skore-hub-project/

File	Stmts	Miss	Cover	Missing
skore-hub-project/src/skore_hub_project
__init__.py	23	1	95%	40
protocol.py	41	0	100%
skore-hub-project/src/skore_hub_project/artifact
__init__.py	0	0	100%
artifact.py	47	1	97%	87
upload.py	30	4	86%	143, 145–146, 148
skore-hub-project/src/skore_hub_project/artifact/media
__init__.py	5	0	100%
data.py	23	0	100%
feature_importance.py	51	1	98%	65
media.py	24	0	100%
model.py	12	0	100%
performance.py	49	0	100%
skore-hub-project/src/skore_hub_project/artifact/pickle
__init__.py	2	0	100%
pickle.py	25	1	96%	51
skore-hub-project/src/skore_hub_project/authentication
__init__.py	0	0	100%
login.py	66	0	100%
logout.py	4	0	100%
token.py	24	0	100%
uri.py	20	0	100%
skore-hub-project/src/skore_hub_project/client
__init__.py	0	0	100%
client.py	68	0	100%
skore-hub-project/src/skore_hub_project/metric
__init__.py	10	0	100%
accuracy.py	35	0	100%
brier_score.py	35	0	100%
log_loss.py	35	0	100%
metric.py	55	4	92%	38, 77–78, 84
precision.py	53	0	100%
r2.py	35	0	100%
recall.py	55	0	100%
rmse.py	35	0	100%
roc_auc.py	35	0	100%
timing.py	76	4	94%	45–46, 104–105
skore-hub-project/src/skore_hub_project/project
__init__.py	0	0	100%
project.py	110	3	97%	242, 323, 353
skore-hub-project/src/skore_hub_project/report
__init__.py	3	0	100%
cross_validation_report.py	73	0	100%
estimator_report.py	10	0	100%
report.py	68	0	100%
TOTAL	1237	19	98%

Tests	Skipped	Failures	Errors	Time
350	0 💤	0 ❌	0 🔥	1m 50s ⏱️

skore-hub-project/src/skore_hub_project/artifact/media/performance.py

skore-hub-project/src/skore_hub_project/artifact/media/data.py

skore-hub-project/pyproject.toml

thomass-dev · 2026-01-16T16:22:41Z

Let's pair review on this PR @rouk1 .

…ression

rouk1

This is really cool and works quite well. Yet I have a few feedbacks.

Progress title feels a bit like an error to me. Probably because of the red color.

rouk1 · 2026-01-20T09:56:31Z

skore-hub-project/src/skore_hub_project/artifact/upload.py

-
-    from ..project.project import Project
-
+    from httpx import Client as httpx_Client


Camel_snake_Case feels odd.

Suggested change

from httpx import Client as httpx_Client

from httpx import Client as HttpxClient

rouk1 · 2026-01-20T09:58:31Z

skore-hub-project/src/skore_hub_project/artifact/upload.py

-        Client() as standard_client,
-        ThreadPoolExecutor() as pool,
-    ):
+    assert filepath.stat().st_size, "`filepath` must not be empty"


Should the size be set in a variable and reused in the with statement below ?

rouk1 · 2026-01-20T10:19:45Z

skore-hub-project/pyproject.toml

 ]
 xfail_strict = true
-filterwarnings = ["error"]
+filterwarnings = [


This seems to be ignored in my setup.
I use interactive views in cursor.

This is only for pytest.

But this warning is not a normal warning, i'm trying to fix it.

thomass-dev self-assigned this Oct 31, 2025

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch from 8e90401 to 15073af Compare November 4, 2025 08:41

thomass-dev mentioned this pull request Nov 5, 2025

feat: Reduce put time #2140

Open

6 tasks

thomass-dev mentioned this pull request Nov 13, 2025

Make cache thread-safe #2153

Open

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch 4 times, most recently from 7455dbc to bace8e0 Compare November 20, 2025 11:20

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch 3 times, most recently from 106d773 to 521a01b Compare November 26, 2025 16:05

thomass-dev mentioned this pull request Nov 27, 2025

feat(skore-hub-project): Thread the compute of report metrics #2178

Merged

thomass-dev changed the base branch from main to skore-hub-project-thread-metrics-computing December 30, 2025 12:33

Base automatically changed from skore-hub-project-thread-metrics-computing to main January 6, 2026 07:49

thomass-dev changed the title ~~feat(skore-hub-project): Use the hash generated by skore to upload a report~~ feat(skore-hub-project): Reduce put time Jan 12, 2026

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch 3 times, most recently from 57e85f9 to 06da771 Compare January 13, 2026 16:01

thomass-dev marked this pull request as ready for review January 13, 2026 16:09

thomass-dev requested a review from rouk1 January 13, 2026 16:10

thomass-dev marked this pull request as draft January 13, 2026 16:14

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch 2 times, most recently from 06da771 to 89d6311 Compare January 14, 2026 14:51

rouk1 requested changes Jan 14, 2026

View reviewed changes

skore-hub-project/src/skore_hub_project/artifact/media/performance.py Outdated Show resolved Hide resolved

skore-hub-project/src/skore_hub_project/artifact/media/data.py Show resolved Hide resolved

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch from 47a69b6 to 741fff7 Compare January 15, 2026 15:14

thomass-dev commented Jan 15, 2026

View reviewed changes

skore-hub-project/pyproject.toml Show resolved Hide resolved

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch from d800e62 to f34ac10 Compare January 16, 2026 13:57

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch from 7e11fca to eb9ec15 Compare January 19, 2026 11:22

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch from eb9ec15 to 834af3d Compare January 20, 2026 09:15

thomass-dev added 6 commits January 20, 2026 10:37

feat(skore-hub-project): Reduce put time

62597a9

fix flakiness

d802ad6

raise exceptions from threads

ab7b8e6

filter matplotlib warning

5747756

fix regression introduced in 94ec184 and fix tests to detect such reg…

005ce00

…ression

filter matplotlib warning

57059fb

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch from ff6fd42 to cb61cbd Compare January 20, 2026 09:39

minor

78e1510

thomass-dev force-pushed the skore-hub-project-use-directly-report-hash branch from cb61cbd to 78e1510 Compare January 20, 2026 09:48

rouk1 requested changes Jan 20, 2026

View reviewed changes

[ci skip] WIP

ba12bb8

thomass-dev mentioned this pull request Jan 29, 2026

Investigate the progress bar of the project.put in VS code #2342

Closed

Disable skore progress-bar

d001b0b

rouk1 mentioned this pull request Feb 11, 2026

uploading... progress bar flashes #2418

Closed

thomass-dev mentioned this pull request Feb 13, 2026

fix(skore): Do not start matplotlib GUI in non-main thread #2459

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(skore-hub-project): Reduce `put` time#2114

feat(skore-hub-project): Reduce `put` time#2114
thomass-dev wants to merge 9 commits intomainfrom
skore-hub-project-use-directly-report-hash

thomass-dev commented Oct 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomass-dev commented Jan 16, 2026

Uh oh!

rouk1 left a comment

Uh oh!

rouk1 Jan 20, 2026

Uh oh!

rouk1 Jan 20, 2026

Uh oh!

rouk1 Jan 20, 2026

Uh oh!

thomass-dev Jan 20, 2026

Uh oh!

thomass-dev Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		from ..project.project import Project

		from httpx import Client as httpx_Client

	from httpx import Client as httpx_Client
	from httpx import Client as HttpxClient

Conversation

thomass-dev commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomass-dev commented Jan 16, 2026

Uh oh!

rouk1 left a comment

Choose a reason for hiding this comment

Uh oh!

rouk1 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

rouk1 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

rouk1 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

thomass-dev Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

thomass-dev Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thomass-dev commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading