Skip to content

feat(skore-hub-project): Thread the compute of report metrics#2178

Merged
rouk1 merged 2 commits intomainfrom
skore-hub-project-thread-metrics-computing
Jan 6, 2026
Merged

feat(skore-hub-project): Thread the compute of report metrics#2178
rouk1 merged 2 commits intomainfrom
skore-hub-project-thread-metrics-computing

Conversation

@thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Nov 27, 2025

Partially addresses #2140, part of the reduce put time task.


Thread the compute of the metrics of a report, and:

  • Add a skinned progress-bar tracking the compute of the metrics of the report,
  • Merge all metric tests into one parametrized test.
  • Disambiguate the metric.value property: when metric.value was called, the computing was performed implicitly, now, metric.compute() must be called before explicitly.

@thomass-dev
Copy link
Collaborator Author

Extracted from #2114.

@thomass-dev thomass-dev force-pushed the skore-hub-project-thread-metrics-computing branch from 03ca0f6 to 72308e4 Compare December 30, 2025 12:04
@thomass-dev thomass-dev marked this pull request as ready for review December 30, 2025 12:12
@github-actions
Copy link
Contributor

Coverage

Coverage Report for skore-hub-project/
FileStmtsMissCoverMissing
skore-hub-project/src/skore_hub_project
   __init__.py23195%40
   protocol.py410100% 
skore-hub-project/src/skore_hub_project/artifact
   __init__.py00100% 
   artifact.py230100% 
   serializer.py280100% 
   upload.py36488%175, 177–178, 180
skore-hub-project/src/skore_hub_project/artifact/media
   __init__.py50100% 
   data.py220100% 
   feature_importance.py45197%53
   media.py100100% 
   model.py100100% 
   performance.py460100% 
skore-hub-project/src/skore_hub_project/artifact/pickle
   __init__.py20100% 
   pickle.py240100% 
skore-hub-project/src/skore_hub_project/authentication
   __init__.py00100% 
   login.py660100% 
   logout.py40100% 
   token.py240100% 
   uri.py200100% 
skore-hub-project/src/skore_hub_project/client
   __init__.py00100% 
   client.py640100% 
skore-hub-project/src/skore_hub_project/metric
   __init__.py100100% 
   accuracy.py350100% 
   brier_score.py350100% 
   log_loss.py350100% 
   metric.py55492%38, 77–78, 84
   precision.py530100% 
   r2.py350100% 
   recall.py550100% 
   rmse.py350100% 
   roc_auc.py350100% 
   timing.py76494%45–46, 104–105
skore-hub-project/src/skore_hub_project/project
   __init__.py00100% 
   project.py105397%226, 307, 337
skore-hub-project/src/skore_hub_project/report
   __init__.py30100% 
   cross_validation_report.py61296%157–158
   estimator_report.py100100% 
   report.py570100% 
TOTAL11881998% 

Tests Skipped Failures Errors Time
234 0 💤 0 ❌ 0 🔥 1m 16s ⏱️

@thomass-dev thomass-dev requested a review from rouk1 January 5, 2026 12:16
Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me LGTM thanks.

@rouk1 rouk1 added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 255f871 Jan 6, 2026
40 checks passed
@rouk1 rouk1 deleted the skore-hub-project-thread-metrics-computing branch January 6, 2026 07:49
glemaitre pushed a commit to auguste-probabl/skore that referenced this pull request Jan 16, 2026
…l-ai#2178)

Partially addresses probabl-ai#2140,
part of the `reduce put time` task.

---

<ins>Thread the compute of the metrics of a report</ins>, and:

- Add a skinned progress-bar tracking the compute of the metrics of the
report,
- Merge all metric tests into one parametrized test.
- Disambiguate the `metric.value` property: when `metric.value` was
called, the computing was performed implicitly, now, `metric.compute()`
must be called before explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants