feat(skore-hub-project): Thread the compute of report metrics#2178
Merged
feat(skore-hub-project): Thread the compute of report metrics#2178
Conversation
Collaborator
Author
|
Extracted from #2114. |
da5090f to
8c79262
Compare
This was referenced Dec 8, 2025
03ca0f6 to
72308e4
Compare
Contributor
Coverage Report for |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| File | Stmts | Miss | Cover | Missing |
|---|---|---|---|---|
| skore-hub-project/src/skore_hub_project | ||||
| __init__.py | 23 | 1 | 95% | 40 |
| protocol.py | 41 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/artifact | ||||
| __init__.py | 0 | 0 | 100% | |
| artifact.py | 23 | 0 | 100% | |
| serializer.py | 28 | 0 | 100% | |
| upload.py | 36 | 4 | 88% | 175, 177–178, 180 |
| skore-hub-project/src/skore_hub_project/artifact/media | ||||
| __init__.py | 5 | 0 | 100% | |
| data.py | 22 | 0 | 100% | |
| feature_importance.py | 45 | 1 | 97% | 53 |
| media.py | 10 | 0 | 100% | |
| model.py | 10 | 0 | 100% | |
| performance.py | 46 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/artifact/pickle | ||||
| __init__.py | 2 | 0 | 100% | |
| pickle.py | 24 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/authentication | ||||
| __init__.py | 0 | 0 | 100% | |
| login.py | 66 | 0 | 100% | |
| logout.py | 4 | 0 | 100% | |
| token.py | 24 | 0 | 100% | |
| uri.py | 20 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/client | ||||
| __init__.py | 0 | 0 | 100% | |
| client.py | 64 | 0 | 100% | |
| skore-hub-project/src/skore_hub_project/metric | ||||
| __init__.py | 10 | 0 | 100% | |
| accuracy.py | 35 | 0 | 100% | |
| brier_score.py | 35 | 0 | 100% | |
| log_loss.py | 35 | 0 | 100% | |
| metric.py | 55 | 4 | 92% | 38, 77–78, 84 |
| precision.py | 53 | 0 | 100% | |
| r2.py | 35 | 0 | 100% | |
| recall.py | 55 | 0 | 100% | |
| rmse.py | 35 | 0 | 100% | |
| roc_auc.py | 35 | 0 | 100% | |
| timing.py | 76 | 4 | 94% | 45–46, 104–105 |
| skore-hub-project/src/skore_hub_project/project | ||||
| __init__.py | 0 | 0 | 100% | |
| project.py | 105 | 3 | 97% | 226, 307, 337 |
| skore-hub-project/src/skore_hub_project/report | ||||
| __init__.py | 3 | 0 | 100% | |
| cross_validation_report.py | 61 | 2 | 96% | 157–158 |
| estimator_report.py | 10 | 0 | 100% | |
| report.py | 57 | 0 | 100% | |
| TOTAL | 1188 | 19 | 98% | |
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 234 | 0 💤 | 0 ❌ | 0 🔥 | 1m 16s ⏱️ |
rouk1
approved these changes
Jan 6, 2026
Contributor
rouk1
left a comment
There was a problem hiding this comment.
Looks good to me LGTM thanks.
glemaitre
pushed a commit
to auguste-probabl/skore
that referenced
this pull request
Jan 16, 2026
…l-ai#2178) Partially addresses probabl-ai#2140, part of the `reduce put time` task. --- <ins>Thread the compute of the metrics of a report</ins>, and: - Add a skinned progress-bar tracking the compute of the metrics of the report, - Merge all metric tests into one parametrized test. - Disambiguate the `metric.value` property: when `metric.value` was called, the computing was performed implicitly, now, `metric.compute()` must be called before explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #2140, part of the
reduce put timetask.Thread the compute of the metrics of a report, and:
metric.valueproperty: whenmetric.valuewas called, the computing was performed implicitly, now,metric.compute()must be called before explicitly.