Skip to content

Fixing translations in the Hindi language #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
42 tasks done
mhsh312 opened this issue Nov 15, 2023 · 11 comments · Fixed by #2729
Closed
42 tasks done

Fixing translations in the Hindi language #2609

mhsh312 opened this issue Nov 15, 2023 · 11 comments · Fixed by #2729

Comments

@mhsh312
Copy link
Contributor

mhsh312 commented Nov 15, 2023

p5.js version

No response

What is your operating system?

Windows

Web browser and version

Microsoft Edge: 118.0.2088.76 (Official build)

Actual Behavior

As mentioned here, the translations of the following phrases is missing for the Hindi language:

  • Nav.Sketch.Title
  • Nav.Auth.Asset
  • Nav.File.Open
  • Nav.File.Duplicate
  • Nav.File.Share
  • SocialAuthButton.LogoARIA
  • About.Forum
  • About.PrivacyPolicy
  • About.TermsOfUse
  • About.CodeOfConduct
  • Preferences.FontSize
  • Preferences.SetFontSize
  • Preferences.AutocompleteHinter
  • Preferences.PlainText
  • Preferences.AutocompleteHinterOnARIA
  • Preferences.AutocompleteHinterOffARIA
  • KeyboardShortcuts.CodeEditing.ColorPicker
  • Common.p5logoARIA
  • NewFileForm.Placeholder
  • NewFolderForm.Placeholder
  • ResetPasswordForm.EmailARIA
  • AccountForm.EmailARIA
  • AccountView.SocialLogin
  • AccountView.AccountTab
  • APIKeyList.Name
  • APIKeyList.Actions
  • SignupForm.EmailARIA
  • AssetList.HeaderName
  • AssetList.HeaderSketch
  • Feedback.Title
  • Collection.HeaderName
  • CollectionCreate.FormLabelARIA
  • DashboardTabSwitcher.Assets
  • CollectionList.HeaderName
  • SketchList.HeaderName
  • Cookies.Header
  • Cookies.Body
  • Cookies.AllowAll
  • Cookies.AllowEssential
  • Legal.PrivacyPolicy
  • Legal.TermsOfUse
  • Legal.CodeOfConduct

I thought of creating this tasked issue because I saw multiple people posting about finding individual un-translationed phrases here and there and this seemed better than creating issues for each one separately over a period of time.
This way, the whole process can be tracked easily making everyone contribute to a one compiled issue.

Expected Behavior

All the phrases should be displayed in Hindi.

Steps to reproduce

  1. Open the editor web app
  2. Click on language preferences
  3. Try changing the different languages and observe the mentioned phrases
  4. Verify that they do not get translated in Hindi
@apsinghdev
Copy link
Contributor

apsinghdev commented Nov 16, 2023

Literally a nice idea, @mhsh312! Is this the final list of phrases that needs to be translated into Hindi? I am asking this because I have gone through the translations.json file, and there are other phrases that are either missing or copied from the English, in addition to the list of phrases provided above.

for example -

Nav.File.Open
Nav.File.Duplicate
Nav.File.Share
Preferences.PlainText

just name a few .

Also I am assuming that we are not translating in Absolute HIndi because that won't be Understandable. We are Translating in hindi words that are prevalent and known by majority of the hindi speakers. So if there is any sort reference /library/module from where we are taking these translations, provide some suggestions.
need your thoughts @lindapaiste

@mhsh312
Copy link
Contributor Author

mhsh312 commented Nov 16, 2023

I don't think it's a final list. These are the ones that lindapaiste found so far. I will keep adding more to these.
About where we could get these translations from, you can check out the PR that I did for the first translation issue (linked in this current issue). I have mentioned how I translated that practicular phrase. Since the PR was merged, I assume that change is acceptable by the maintainers.

@umangutkarsh
Copy link
Contributor

umangutkarsh commented Dec 5, 2023

Maintainers, @lindapaiste @mhsh312 . I've opened a pr to fix the translation-error-issue of 'AutocompleteHinter', please review it and provide feedback if anything else is required.
Thanks.

@umangutkarsh
Copy link
Contributor

umangutkarsh commented Dec 6, 2023

Hi @lindapaiste . I've opened some more PRs. Please take out your time and review those. And if there's anything which needs to be worked upon in these PRs and the other PRs, then please let me know.
Thanks

@umangutkarsh
Copy link
Contributor

Hi @lindapaiste . I've opened some more PRs. Please take out your time and review those. And if there's anything which needs to be worked upon in these PRs and the other PRs, then please let me know. Thanks

@lindapaiste . Any updates? Or are there any changes required in the PRs?

@ajaysharma-dev
Copy link

I've added Hindi translation of Cookies object #2706 .

@shaleshkalyan
Copy link

Added hindi translation of Legal object #2708

umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 13, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 13, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 13, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 13, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 15, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 15, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 15, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 15, 2023
@reach2saksham
Copy link
Contributor

reach2saksham commented Dec 15, 2023

Hello Maintainers,

I compared the English translation file with the Hindi translation JSON file and have added all the missing keys in the pull request #2729.

Request you to kindly review and merge.

Regards,
Saksham Jain
IIT Roorkee

umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 16, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 16, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 16, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 16, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 17, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 17, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 17, 2023
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Dec 17, 2023
@Swarnendu0123
Copy link
Contributor

Swarnendu0123 commented Dec 18, 2023

Hello @umangutkarsh, #2691 and #2699 are almost the same, the only difference is #2699 converts the translation in all available languages but #2691 translates only in Hindi. It will cause many problems when language is changed from one to another. Always we have to keep in mind and check our codes
multiple times before making any PRs, because it can cause errors in production.

What do you think @raclim @lindapaiste ?

umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Jan 2, 2024
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Jan 2, 2024
@umangutkarsh
Copy link
Contributor

Hi @lindapaiste . I've opened some more PRs. Please take out your time and review those. And if there's anything which needs to be worked upon in these PRs and the other PRs, then please let me know. Thanks

Hey @lindapaiste . Hope it doesn't burden you, but any updates?
Thanks :)

@raclim raclim added this to the MINOR Release for 2.12.0 milestone Jan 19, 2024
raclim added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Jan 25, 2024
raclim added a commit that referenced this issue Jan 25, 2024
raclim added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Jan 25, 2024
@raclim raclim reopened this Jan 25, 2024
umangutkarsh added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Jan 25, 2024
raclim added a commit to umangutkarsh/p5.js-web-editor that referenced this issue Jan 25, 2024
raclim added a commit that referenced this issue Jan 25, 2024
@raclim
Copy link
Collaborator

raclim commented Jan 25, 2024

Thanks for all of your work and input here on this!

I just reviewed the file and it seems like a translation was ascribed to all of the listed phrases. I'm going to close this for now since it seems to be complete, but please definitely feel free to open up a new issue if any changes or new translation fixes are needed!

@raclim raclim closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants