-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Converted 'About Block' into all available language #2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lindapaiste @raclim Can you please review the PR? and give your feedback. |
Thanks for your work on this! I think it would be great to get this one in before the upcoming release on February 15! I just merged in #2691, which starts these changes in the 'About' modal and I think caused some merge conflicts here. Would you be able to resolve them before the release? |
Yes definitely, I would resolve it by tonight. |
conflicts resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds back in the "Donate" link that was added and removed with the fundraiser campaign, but ideally we do want to keep this in so I think it's great that this is here!
I did intend to merge this a while back so I'm going to get this in! There could be a few translation issues, but I'm hoping they could be raised down the line.
Fixes #2692, Ref #2609
Changes:
Trems Web Editor, Home, Twitter, Instagram, Discord changed in About Block
About Block is now completely in all available languages:
Bengali
Spanish (Latin America)
French
German
Italian
Hindi
Japanese
Korean
Portuguese
Swedish
Turkish
Ukrainian
Simplified Chinese
Traditional Chinese
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123