Skip to content

Use FES internationalization within the minor version #7878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use FES internationalization within the minor version #7878

wants to merge 1 commit into from

Conversation

ksen0
Copy link
Member

@ksen0 ksen0 commented Jun 4, 2025 •
edited
Loading

Addresses #7813

const version = '1.11.7';
const loadPath = 'https://cdn.jsdelivr.net/npm/p5@' + version.replace(/^(\d+\.\d+)\.\d+.*$/, '$1') + '/translations/{{lng}}/{{ns}}.json';
console.log(loadPath);
// https://cdn.jsdelivr.net/npm/[email protected]/translations/{{lng}}/{{ns}}.json
// will become https://cdn.jsdelivr.net/npm/[email protected]/translations/es/translation.json which exists

@ksen0 ksen0 force-pushed the fes-version branch 3 times, most recently from aa7780b to a8bbc48 Compare June 4, 2025 19:30
@ksen0 ksen0 marked this pull request as ready for review June 4, 2025 19:32
@ksen0 ksen0 requested a review from limzykenneth June 4, 2025 19:32
@ksen0 ksen0 changed the title Use FES internationalization within the minor version [WIP] Use FES internationalization within the minor version Jun 5, 2025
limzykenneth
limzykenneth reviewed Jun 8, 2025
View reviewed changes
Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took awhile to get to. One suggestion on alternative approach.

src/core/internationalization.js
Comment on lines +3 to +4
import { version } from '../../package.json';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browserify used by the 1.x branch does not treeshake JSON which means the whole package.json file will be included in the build with this. We have the version number exported by core/constants.js so we can import that and use that value directly instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limzykenneth limzykenneth limzykenneth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksen0 @limzykenneth