Skip to content

Use FES internationalization within the minor version #7878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use FES internationalization within the minor version #7878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ad63d7
Use FES internationalization within the minor version
ksen0 Jun 4, 2025
3887266
User constants.VERSION for version-aware FES localisation
ksen0 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core/internationalization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import i18next from 'i18next';
import LanguageDetector from 'i18next-browser-languagedetector';
import * as constants from './constants';


let fallbackResources, languages;
if (typeof IS_MINIFIED === 'undefined') {
Expand Down Expand Up @@ -127,6 +129,7 @@ export let translator = (key, values) => {
* Set up our translation function, with loaded languages
*/
export const initialize = () => {
let latestMinorVersionPath = 'https://cdn.jsdelivr.net/npm/p5@' + constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksen0 , @limzykenneth just a thought here.
Will it be a better idea to separate out the base CDN URL here and the version parsing logic for better readability and reusability too, and then compose the final loadPath. I was thinking to encapsulate it like below:

const getCDNPath = (() => {
  const base = 'https://cdn.jsdelivr.net/npm/p5@';
  const version = constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1');
  return `${base}${version}`;
})();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth to split it out in this way, especially also encapsulating it in a function, if needed, just a string interpolation should suffice as well.

`https://cdn.jsdelivr.net/npm/p5@${constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1')}`

Copy link
Contributor

@IIITM-Jay IIITM-Jay Jun 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that there's no broader scope for reusability in this case, so I agree — using direct string interpolation is sufficient and keeps it clean.

Copy link
Contributor

@IIITM-Jay IIITM-Jay Jun 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial thought was that separating the base URL and version logic might help with readability and clarity, especially if more dynamic paths were ever added later. But given the current usage, simplicity could be more prioritized.

Thanks for sharing this!

let i18init = i18next
.use(LanguageDetector)
.use(FetchResources)
Expand All @@ -149,8 +152,7 @@ export const initialize = () => {
},
backend: {
fallback: 'en',
loadPath:
'https://cdn.jsdelivr.net/npm/p5/translations/{{lng}}/{{ns}}.json'
loadPath: latestMinorVersionPath + '/translations/{{lng}}/{{ns}}.json'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then here, we could compose it like

loadPath: `${getCDNPath}/translations/{{lng}}/{{ns}}.json`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then I think with string interpolation we could simply write with one liner change:

loadPath: `https://cdn.jsdelivr.net/npm/p5@${constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1')}/translations/{{lng}}/{{ns}}.json`

},
partialBundledLanguages: true,
resources: fallbackResources
Expand Down