Repository navigation
Show saved-value warnings with plain paths and links in the terminal - #3224
Open
Howard-149 wants to merge 1 commit into
Open
Howard-149 wants to merge 1 commit into
Howard-149 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The Markdown, HTML and separator escaping in formatReplayEvidence is for the PR body. The runner's command output now passes terminal: true, so warnings keep the JSON form, Unicode escapes and inert markers but show tests/add.json instead of tests&promptdriven#47;add.json. Fixes promptdriven#2953.
Howard-149
force-pushed
the
fix/2953-plain-terminal-warnings
branch
from
November 16, 2026 16:08
54cf46c to
fcdc29a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2953.
Status
main02db5b9 (Nov 16). The patch is unchanged; only the hashes and two context lines frommainmoved (see Interface).promptdriven/runtime-client. A fork PR gets noRUNTIME_CLIENT_DEPLOY_KEY, soinstall-smokeand the test shards stop at the install step ("No configured secret has read access to promptdriven/runtime-client") before any test runs. Could you run CI with the secret, or rerun it from a branch in this repo?prompts/cli/workflow-replay.prompt.md. Whichever merges second needs a rebase and interface re-approval.Problem
Saved-value warnings in the command output used the PR body's escaping, so the terminal showed
tests/add.jsonandhttps://…instead of plain paths and links.Change
prompts/cli/workflow-replay.prompt.md: the Markdown, HTML and separator escaping is for the PR body only. With optionterminaltrue, warnings keep the JSON form, Unicode escapes and inert markers, and show paths and links as plain text.src/workflow-replay.mjs:formatReplayEvidence(result, {terminal}). The PR form is built on the same plain form, so it is unchanged.src/workflow-runner.mjs: the two command-output call sites passterminal: true. The PR-body call sites are unchanged.Before / after in the terminal:
Interface
The prose change makes the approved Runtime interface of
workflow-replay.prompt.mdstale, so it isdraftagain and needs re-approval. After the rebase,prose_sha256is08c72da1…and the header insrc/workflow-replay.mjsis the behavior hash8b0758bc…(#3200). I could not runpdd test --fill-hashorpdd ownerhere, because both now need@promptdriven/runtime-client. I computed both values with the same rules as the pre-split code (proseSha256fromruntime-preflight.mjsat bce70f6,promptHeaderHashfromfile-owner.mjs), and checked those rules first: they reproducemain's recorded1e33b057…/f9778f1a…and this branch's earliere472fee8…/4caf4584…exactly.In
src/workflow-runner.mjs,main's newnoPublishandlocalPublicationconditions are kept; this PR only addsterminal: truethere.Tests
New
2953unit test: the terminal form showstests/add_one.jsonand"https://example.com/a?x=1&y=2"as typed, keepspdd-workflow:andescaped, and the PR form still escapes.The
2870runner test now checks the terminal message readstests/add.json /steps/0/checks/0/value 3 -> 999with no/.A/B on the same new test (
node --import ./test/helpers/test-home.mjs --test --test-name-pattern='^2953:' test/workflow-replay.test.mjs), on the last base that has the Runtime code in this repo:src/andprompts/frommainbce70f6On the new base 02db5b9 I can't run it: the replay path calls
gitFiles,formatand other functions that now live in the private package.git range-diffshows the rebased patch is the same apart from the hashes andmain's context lines.Before this rebase, on
mainbce70f6:workflow-replay,workflow-runner,workflow-base-corpus,workflow-pr-publicationandfile-ownergave 340/341 pass. The one failure,3088 repair 1: scenario-only publication…, also fails onmain9341f3b.Full suite before the first rebase (macOS, mock keychain): branch 8,286/8,389 pass,
main9341f3b 8,274/8,388 pass. Every branch failure also fails onmain, except four that pass on rerun.The rebases kept #3150's exact large numbers in the warning line.
Question
A Try link inside a saved value now shows as a plain link in the terminal (it is still escaped in the PR). Command output is local, so I think that is fine, but the prompt asks to sanitize Try capabilities in displayed details. Should the terminal form remove Try links instead?