Skip to content

fix(replay): show plain paths and links in terminal saved-value warnings (#2953) - #3501

Merged
Serhan-Asad merged 2 commits into
mainfrom
fix/2953-terminal-plain-paths
Nov 17, 2026
Merged

Serhan-Asad merged 2 commits into
mainfrom
fix/2953-terminal-plain-paths

Conversation

@Serhan-Asad

@Serhan-Asad Serhan-Asad commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #2953 (#2953)
Supersedes #3224 (cross-repository fork PR that conflicted with main and lacked private CI secrets; credits @Howard-149 as co-author).

Lines changed: +113 / -29 across 6 files.

What changed

  • Updated prompts/cli/workflow-replay.prompt.md and prompts/cli/workflow-runner.prompt.md first, keeping prose_sha256 and src/workflow-replay.mjs provenance hash current.
  • Updated render, anchorLine, formatFormalEvidence, and formatReplayEvidence in src/workflow-replay.mjs so terminal: true preserves C0/C1/ANSI stripping, Try-link redaction, and pdd-workflow: / pdd-product: marker neutralization while rendering paths, links, adoption/anchor notes, and formal scope/reason as plain text without Markdown backslash or HTML entity escaping.
  • Passed terminal: true in command output (finishPr, stepDoneCommand, and runtimeStatusLines for pdd workflow status/view) while keeping PR body formatting escaped.
  • Expanded test/workflow-replay.test.mjs and test/workflow-runner.test.mjs to cover underscore vector paths, adoption/anchor/formal metadata with _ and &, and small-change terminal status output.

Verification

  • TMPDIR=/private/tmp node --import ./test/helpers/test-home.mjs --import ./test/helpers/test-net-guard.mjs --test test/workflow-replay.test.mjs test/metrics-runner-interface.integration.test.mjs test/file-owner.test.mjs test/repo-hygiene-lint.test.mjs — 54/54 pass.
  • TMPDIR=/private/tmp node --import ./test/helpers/test-home.mjs --import ./test/helpers/test-net-guard.mjs --test --test-name-pattern='2870' test/workflow-runner.test.mjs — 6/6 pass.

No Story: internal terminal-versus-PR warning formatting refinement in workflow replay and runner status output.

Serhan-Asad and others added 2 commits November 17, 2026 12:26
@Serhan-Asad
Serhan-Asad merged commit 5c7e658 into main Nov 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changed test-value warnings show escaped slashes (/) in the terminal

1 participant