(PE-37704) Allow for SLES-11 (Intel) builds to be installed in PE 2021.7.x for testing

[shubhamshinde360]

• Define method to install sles-11 rpm from agent-downloads since it is not present in PE.
• Define rspec to test the above method.
• Adds a new mock sles11 host to the hosts list for the rspec.
• Expect get_mco_setting() to be received twice instead of once for the subject, one for osx host (already existed before this commit), another for sles11 host (added in this commit).

[joshcooper]

Tests passed after rekicking: https://jenkins-sre.delivery.puppetlabs.net/job/sre_beaker-pe_integration-system_latest-pe_main/822/

[joshcooper]

@shubhamshinde360 I think the changes are mostly fine with a few minor comments. Could you add a unit test to pe_utils_spec.rb to verify Host#install_package_from_rpm gets called with the expected url?

I'd probably create a sles 11 host similar to what's done in

beaker-pe/spec/beaker-pe/install/pe_utils_spec.rb

Lines 48 to 52 in 6f77430

	let(:unixhost) { make_host( 'unixhost', { :platform => 'linux',
	:pe_ver => '3.0',
	:type => 'pe',
	:working_dir => '/tmp',
	:dist => 'puppet-enterprise-3.1.0-rc0-230-g36c9e5c-debian-7-i386' } ) }

Append that host to the list of hosts in

beaker-pe/spec/beaker-pe/install/pe_utils_spec.rb

Line 37 in 6f77430

basic_hosts[3][:platform] = 'eos'

Then verify the hosts[4] receives the expected call, similar to how it's handled for macOS and EOS/swix:

beaker-pe/spec/beaker-pe/install/pe_utils_spec.rb

Lines 1667 to 1668 in 6f77430

	expect( subject ).to receive( :on ).with( hosts[2], / hdiutil attach puppet-enterprise-3.0-osx-10.9-x86_64.dmg && installer -pkg \/Volumes\/puppet-enterprise-3.0\/puppet-enterprise-installer-3.0.pkg -target \// ).once
	expect( hosts[3] ).to receive( :install_from_file ).with( /swix$/ ).once

Also can you provide details how you're testing this? I was able to do the following. Note I'm explicitly not adding the frictionless role:

#!/bin/bash

export GEM_SOURCE=https://artifactory.delivery.puppetlabs.net/artifactory/api/gems/rubygems/
export BEAKER_PE_VERSION=file:///home/josh/work/beaker-pe
export UPGRADE_FROM=NONE
export UPGRADE_TO_VERSION=NONE
export pe_version=2021.7.8-rc1-60-g52a023c
export pe_dep_versions=config/versions/pe_version
export MT_COMPAT=true

bundle update
bundle exec beaker-hostgenerator centos7-64mcd-sles11-64a --hypervisor abs --global-config 'ssh={forward_agent=true}' > hosts.cfg
bundle exec beaker init --hosts hosts.cfg \
 --debug \
 --type pe \
 --keyfile ~/.ssh/id_rsa-acceptance \
 --tests acceptance/tests \
 --helper lib/beaker_helper.rb \
 --pre-cleanup acceptance/post \
 --pre-suite setup/install.rb \
 --test-tag-exclude pe_infra_only,security
bundle exec beaker provision
bundle exec beaker exec setup/install.rb

[joshcooper]

This needs to land in a beaker-pe 2.x release so that it can be used in PE 2021.7.x pipelines. Only PE 2023 is using beaker-pe because of the password complexity changes.

[joshcooper]

Adding @steveax and @nmburgan for visibility

[shubhamshinde360]

Hey @joshcooper,

I was testing this earlier as

• export BEAKER_PE_VERSION=file:///Users/shubham.shinde/repositories/beaker-pe
• bundle install
• bundle exec beaker-hostgenerator --hypervisor abs --pe_ver=2021.7.8-rc1-47-ged6307d --pe_dir=https://artifactory.delivery.puppetlabs.net/ui/native/generic_enterprise__local/2021.7/ci-ready centos7-64mcda-sles11-64a > hosts.cfg
• bundle exec beaker --hosts hosts.cfg --helper lib/beaker_helper.rb --pre-suite setup/install.rb --type pe --debug

Not sure if this is ok. So I also tried using what you have suggested above and it passed too. Thanks!

[joshcooper]

@shubhamshinde360 can you backport the release prep workflow to the 2.x branch and prep for a beaker-pe release as described in https://github.com/puppetlabs/beaker-pe?tab=readme-ov-file#releasing?