(PE-37704) Allow for SLES-11 (Intel) builds to be installed in PE 2021.7.x for testing#264
Merged
Conversation
shubhamshinde360
commented
Apr 1, 2024
shubhamshinde360
commented
Contributor
- Define method to install sles-11 rpm from agent-downloads since it is not present in PE.
- Define rspec to test the above method.
- Adds a new mock sles11 host to the hosts list for the rspec.
- Expect get_mco_setting() to be received twice instead of once for the subject, one for osx host (already existed before this commit), another for sles11 host (added in this commit).
…1.7.x for testing - Define method to install sles-11 rpm from agent-downloads since it is not present in PE. - Define rspec to test the above method. - Adds a new mock sles11 host to the hosts list for the rspec. - Expect get_mco_setting() to be received twice instead of once for the subject, one for osx host (already existed before this commit), another for sles11 host (added in this commit).
joshcooper
approved these changes
Apr 2, 2024
joshcooper
left a comment
joshcooper
left a comment
Contributor
There was a problem hiding this comment.
This looks to be a backport of #259
In the future when backporting commits, can you cherry-pick them with git cherry-pick -x <SHA> so that the git commit summary has a reference to the the SHA from which it came?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.