Cleanup docker support #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* os_release facts added to docker_exp * container_id fact added to docker * consistent naming convention, remove generated name from docker (use id)
should make writing tests easier
duplicate method
* tmpdir missing from docker_exp run * docker_exp docker_run_opts optional * use container_id as node name for both implementations
* dropped archlinux as it never worked * support opensuse ssh service start
h0tw1r3
force-pushed
the
docker-dodo
branch
2 times, most recently
from
2da4c6f to
2bf8841
Compare
|
Need to address failures on CentOS 6: https://github.com/puppetlabs/litmusimage/actions/runs/7912801403 |
|
Smoke tests passing 💯 |
|
@h0tw1r3 this is great! Just a small hitch in my testing, the docker_exp task seems to be broken. This doesn't happen when running on main: Hope this isn't too big of an issue for you, just seems we are referncing an undefined variable |
|
@jordanbreen28 forgot to push the fix. Thanks! |
jordanbreen28
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are simply housekeeping. Reconcile the two docker tasks to ensure they create containers and manage the bolt inventory in exactly the same way. After this I'm hoping we can move to supporting unprivileged docker containers.
These changes can be tested running the manual workflow on Litmusimage using
{ "git": "https://github.com/h0tw1r3/provision.git", "ref": "docker-dodo" }for the provision module option after puppetlabs/litmusimage#75 is merged.