Skip to content

fix bolt tasks with docker_exp transport #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Feb 18, 2024

tldr; #257 broke running bolt commands against docker_exp provisioned containers

Behind the scenes, the bolt docker transport uses docker cp to upload and dowload files to the containers.
Unfortunately, we're using --tmpfs /tmp when creating containers, so docker cp is unable to upload or download to that path (or any tmpfs path). Technically it's uploading files to the container filesystem, but...

From docker cp documentation corner cases:

It isn't possible to copy certain system files such as resources under /proc, /sys, /dev, tmpfs, and mounts created by the user in the container. However, you can still copy such files by manually running tar in docker exec.

Ultimately the problem needs to be solved in the bolt docker transport, but that's a much harder problem to solve. For now, not mounting tmpfs fixes this problem.

Unknown option 'connect-timeout' at 'groups.0.targets.0.config.docker' at spec/fixtures/litmus_inventory.yaml. [ID: unknown_option]
@jordanbreen28 jordanbreen28 merged commit 9435bc4 into puppetlabs:main Feb 19, 2024
@h0tw1r3 h0tw1r3 deleted the fix-docker-cp branch February 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants