Added support for Java VM options#37
Conversation
There was a problem hiding this comment.
It's probably worth mentioning here what exactly that default means. If I'm reading your code correctly the default is to just leave the settings that were layed down by the package--which I believe is indeed the correct behavior, but reading the current docs doesn't make that entirely clear.
We might even want to include a link to the public puppetdb docs so folks can see what the defaults are.
|
This looks good to me. Will hold off on merging it until after the inifile pull gets in. Thanks! |
There was a problem hiding this comment.
Can you namespace this with puppetdb_ ...? Just makes finding the source of the function easier for users :-).
There was a problem hiding this comment.
ok, I'll change the name
|
@kbrezina thanks... I'm +1 on this as soon as we merge the inifile stuff. @kbarber we will need to be careful with the timing on merging this in, because doing so will require updaing the modulefile to depend on a newer version of inifile. If you are wanting to get a release out prior to that, then we should hold off on merging this until your release goes out. |
|
@cprice-puppet how are we with this now? I wouldn't mind a release this week, but I can wait. |
|
@kbarber I think I still haven't merged his inifile pull req, so we're blocked on that. |
|
I think this should be merged (the inifile changes have already been merged). |
|
@fhrbek can you rebase the pull request, its out of date. |
|
Rebased. |
Added support for Java VM options
5 participants
https://sprint.ly/product/7841/#!/item/120