Skip to content

Allow npm install of spago@next #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
natefaubion opened this issue Dec 14, 2023 · 3 comments
Closed

Allow npm install of spago@next #37

natefaubion opened this issue Dec 14, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@natefaubion
Copy link

Currently spago is hardcoded to use github releases for legacy spago. Would it be possible to use npm for install for spago next/unstable?

@natefaubion
Copy link
Author

Current workaround is to install spago in a step using npm and invoke from node_modules/.bin or npx.

@thomashoneyman
Copy link
Collaborator

Yes, we would need to update this:

Spago -> Tarball
{ source: formatGitHub'
-- Spago has changed naming conventions from version to version
if version >= unsafeVersion "0.18.1" then case platform of
Windows -> "Windows"
Mac -> "macOS"
Linux -> "Linux"
else if version == unsafeVersion "0.18.0" then case platform of
Windows -> "windows-latest"
Mac -> "macOS-latest"
Linux -> "linux-latest"
else case platform of
Windows -> "windows"
Mac -> "osx"
Linux -> "linux"
, getExecutablePath: \p -> Path.concat [ p, executableName ]

...such that if the Spago version is greater than 0.90.x then we use NPM as the installation method.

@thomashoneyman thomashoneyman added the help wanted Extra attention is needed label Dec 14, 2023
@thomashoneyman
Copy link
Collaborator

We would also need to update the get latest versions script so that it looks at NPM releases for Spago; right now everything looks at GitHub releases, but the spago@next releases are not happening on GitHub releases at all.

Spago -> fetchFromGitHubReleases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

No branches or pull requests

2 participants