Skip to content

feat(#37): support spago@next -> the latest and unstable are both spago@next version, BREAKING CHANGE #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 11, 2024

Conversation

srghma
Copy link
Member

@srghma srghma commented Mar 16, 2024

@srghma srghma changed the title feat(#37): support spago@next -> the last and unstable are both spago@next version, BREAKING CHANGE feat(#37): support spago@next -> the latest and unstable are both spago@next version, BREAKING CHANGE Mar 16, 2024
@srghma
Copy link
Member Author

srghma commented Mar 16, 2024

hi @thomashoneyman
I have implemented as You suggested

@jamesdbrock
Copy link
Member

I just ran the workflow and it passes. This PR looks good to me.

registry: 50.4.0
extra_packages:
github-actions-toolkit:
# git: "https://github.com/purescript-contrib/purescript-github-actions-toolkit.git"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesdbrock I’d like to wait to merge this until we can point at the non-forked GitHub actions toolkit library

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake.nix Outdated
Comment on lines 26 to 29
packages = forAllSystems (system:
let pkgs = nixpkgsFor.${system}; in {
default = pkgs.hello; # your package here
});
Copy link
Collaborator

@thomashoneyman thomashoneyman Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're only using a devshell so we should remove this packages section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed too

commented out and

 ~/projects/setup-purescript   main  nix shell
warning: Git tree '/home/srghma/projects/setup-purescript' is dirty
error: flake 'git+file:///home/srghma/projects/setup-purescript' does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'
 ✘  ~/projects/setup-purescript   main ±  nix shell #.devShells
warning: Git tree '/home/srghma/projects/setup-purescript' is dirty
error: flake 'git+file:///home/srghma/projects/setup-purescript' does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'

@thomashoneyman
Copy link
Collaborator

@srghma other than my two minor comments this looks good to me and I can approve & merge. However, looks like the Windows CI is failing; not sure why it's failing the formatter check and I don't have any experience with Windows myself. Maybe @JordanMartinez or @f-f have seen something like this before?

@f-f
Copy link

f-f commented Apr 4, 2024

Not sure I encountered exactly this before, but I wonder if this is due to the git line endings - in Spago's CI we have this snippet before the actions/checkout step:

    steps:
      # We set LF endings so that the Windows environment is consistent with the rest
      # See here for context: https://github.com/actions/checkout/issues/135
      - name: Set git to use LF
        run: |
          git config --global core.autocrlf false
          git config --global core.eol lf
          git config --global core.longpaths true

@thomashoneyman
Copy link
Collaborator

We can also just not do the formatting check on windows

@thomashoneyman thomashoneyman merged commit 6ccd9e0 into purescript-contrib:main Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants