-
Notifications
You must be signed in to change notification settings - Fork 8
feat(#37): support spago@next -> the latest and unstable are both spago@next version, BREAKING CHANGE #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ble are both spago@next version, BREAKING CHANGE
hi @thomashoneyman |
I just ran the workflow and it passes. This PR looks good to me. |
registry: 50.4.0 | ||
extra_packages: | ||
github-actions-toolkit: | ||
# git: "https://github.com/purescript-contrib/purescript-github-actions-toolkit.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesdbrock I’d like to wait to merge this until we can point at the non-forked GitHub actions toolkit library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can now be updated to https://github.com/purescript-contrib/purescript-github-actions-toolkit/releases/tag/v0.6.0 (cc: @srghma)
…o.latest - spago@latest, spago.unstable - spago@next, regenerate
flake.nix
Outdated
packages = forAllSystems (system: | ||
let pkgs = nixpkgsFor.${system}; in { | ||
default = pkgs.hello; # your package here | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're only using a devshell so we should remove this packages
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed too
commented out and
~/projects/setup-purescript main nix shell
warning: Git tree '/home/srghma/projects/setup-purescript' is dirty
error: flake 'git+file:///home/srghma/projects/setup-purescript' does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'
✘ ~/projects/setup-purescript main ± nix shell #.devShells
warning: Git tree '/home/srghma/projects/setup-purescript' is dirty
error: flake 'git+file:///home/srghma/projects/setup-purescript' does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'
@srghma other than my two minor comments this looks good to me and I can approve & merge. However, looks like the Windows CI is failing; not sure why it's failing the formatter check and I don't have any experience with Windows myself. Maybe @JordanMartinez or @f-f have seen something like this before? |
Not sure I encountered exactly this before, but I wonder if this is due to the git line endings - in Spago's CI we have this snippet before the
|
We can also just not do the formatting check on windows |
#37
depends on purescript-contrib/purescript-github-actions-toolkit#20