Skip to content

Specify angle units in pvlib.location.Location.get_solarposition #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cwhanse opened this issue Sep 24, 2021 · 0 comments · Fixed by #1336
Closed

Specify angle units in pvlib.location.Location.get_solarposition #1314

cwhanse opened this issue Sep 24, 2021 · 0 comments · Fixed by #1336
Labels
documentation easy enhancement good first issue
Milestone
0.9.1

Comments

@cwhanse
Copy link
Member

cwhanse commented Sep 24, 2021 •
edited
Loading

The docstring for pvlib.location.Location.get_solarposition doesn't specify that the returned solar angles are in units of degrees. It could. Discussion here.
@cwhanse cwhanse added this to the 0.9.1 milestone Sep 24, 2021
Carlosbogo added a commit to Carlosbogo/pvlib-python that referenced this issue Nov 5, 2021
@Carlosbogo
PR for issue pvlib#1314
cd9f4ba
@Carlosbogo Carlosbogo mentioned this issue Nov 5, 2021
Merged
mikofski pushed a commit that referenced this issue Nov 5, 2021
@Carlosbogo
PR for issue #1314 (#1336)
e47f2d4
cwhanse pushed a commit that referenced this issue Dec 10, 2021
@Carlosbogo @kandersolar
Documentation: Add note to irradiance.haydavies docstring. Close #1352 (
9aed6b7 
#1353)

* PR for issue #1314

* Documentation: Added note to `irradiance.haydavies` docstring. Close #1352

Added a note about projection_ratio parameter to `irradiance.haydavies` docstring as mentioned by @kanderso-nrel .

* Documentation: Add note to irradiance.haydavies docstring. Update #1353

Added the changes suggested by @kanderso-nrel

Co-authored-by: Kevin Anderson <[email protected]>

Co-authored-by: Kevin Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation easy enhancement good first issue
Projects
None yet
Milestone
0.9.1
Development

Successfully merging a pull request may close this issue.

PR for issue #1314 Carlosbogo/pvlib-python
1 participant
@cwhanse