Skip to content

Add note to irradiance.haydavies docstring about projection_ratio parameter #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kandersolar opened this issue Dec 8, 2021 · 2 comments · Fixed by #1353
Closed

Add note to irradiance.haydavies docstring about projection_ratio parameter #1352

kandersolar opened this issue Dec 8, 2021 · 2 comments · Fixed by #1353
Labels
documentation good first issue help wanted
Milestone
0.9.1

Comments

@kandersolar
Copy link
Member

Is it worthwhile to add a similar note to irradiance.haydavies? Something like "When supplying projection_ratio, consider constraining its values when zenith angle approaches 90 degrees. See code for details." Certainly not required here.

Originally posted by @wholmgren in #1349 (review)
@Carlosbogo
Copy link
Contributor

Hi, if needed I would like to work on this issue.

@cwhanse
Copy link
Member

cwhanse commented Dec 8, 2021

@Carlosbogo you are welcome to do it. Thanks!

@cwhanse cwhanse added this to the 0.9.1 milestone Dec 8, 2021
Carlosbogo added a commit to Carlosbogo/pvlib-python that referenced this issue Dec 8, 2021
@Carlosbogo
Documentation: Added note to irradiance.haydavies docstring. Close p…
114bfc1 
…vlib#1352

Added a note about projection_ratio parameter to `irradiance.haydavies` docstring as mentioned by @kanderso-nrel .
@Carlosbogo Carlosbogo mentioned this issue Dec 8, 2021
Merged
cwhanse pushed a commit that referenced this issue Dec 10, 2021
@Carlosbogo @kandersolar
Documentation: Add note to irradiance.haydavies docstring. Close #1352 (
9aed6b7 
#1353)

* PR for issue #1314

* Documentation: Added note to `irradiance.haydavies` docstring. Close #1352

Added a note about projection_ratio parameter to `irradiance.haydavies` docstring as mentioned by @kanderso-nrel .

* Documentation: Add note to irradiance.haydavies docstring. Update #1353

Added the changes suggested by @kanderso-nrel

Co-authored-by: Kevin Anderson <[email protected]>

Co-authored-by: Kevin Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue help wanted
Projects
None yet
Milestone
0.9.1
Development

Successfully merging a pull request may close this issue.

Documentation: Add note to irradiance.haydavies docstring. Close #1352 Carlosbogo/pvlib-python
3 participants
@cwhanse @kandersolar @Carlosbogo