Skip to content

remove irradiance parameter from ModelChain.run_model #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wholmgren opened this issue Jun 23, 2018 · 5 comments
Closed

remove irradiance parameter from ModelChain.run_model #488

wholmgren opened this issue Jun 23, 2018 · 5 comments
Labels
api easy help wanted
Milestone
0.6.0

Comments

@wholmgren
Copy link
Member

#239 deprecated the irradiance parameter in ModelChain.run_model. It's time to remove it.
@wholmgren wholmgren added the api label Jun 23, 2018
@wholmgren wholmgren added this to the 0.6.0 milestone Jun 23, 2018
@alamathe1
Copy link
Contributor

@wholmgren Can I please help on this?

@wholmgren
Copy link
Member Author

sure, feel free to make a pull request. I should add that the parameter needs to be removed from ModelChain.prepare_inputs as well.

@alamathe1
Copy link
Contributor

@wholmgren I have removed the irradiance parameter from ModelChain.run_model and ModelChain.prepare_inputs. Is there any preferred tests that needs to be run or shall I raise a PR?

@wholmgren
Copy link
Member Author

It looks to me like the pvlib/test/test_modelchain.py::test_weather_irradiance_input function needs to be removed, but otherwise no changes needed to the tests.

alamathe1 added a commit to alamathe1/pvlib-python that referenced this issue Jun 23, 2018
@alamathe1
Addressed Issue pvlib#488
4083fe5
@alamathe1
Copy link
Contributor

@wholmgren Raised #490 Please let me know if there's any modifications required to the PR.

@alamathe1 alamathe1 mentioned this issue Jun 23, 2018
Merged
6 tasks
wholmgren pushed a commit that referenced this issue Jun 26, 2018
@alamathe1 @wholmgren
remove irradiance parameter from ModelChain.run_model and ModelChain.…
fe5d90d 
…prepare_inputs (#490)

* Addressed Issue #488

* Removed comments related to irradiance parameter

* Updated API section of docs/sphinx/source/whatsnew/v0.6.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api easy help wanted
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@wholmgren @alamathe1