Skip to content

remove irradiance parameter from ModelChain.run_model and ModelChain.prepare_inputs #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2018

Conversation

alamathe1
Copy link
Contributor

@alamathe1 alamathe1 commented Jun 23, 2018

pvlib python pull request guidelines

Thank you for your contribution to pvlib python!

You may submit a pull request with your code at any stage of completion, however, before the code can be merged the following items must be addressed:

  • Closes remove irradiance parameter from ModelChain.run_model #488
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

Please don't hesitate to ask for help if you're unsure of how to accomplish any of the above. You may delete all of these instructions except for the list above.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a note to the api section of docs/sphinx/source/whatsnew/v0.6.0.rst as well as your name or username

@@ -754,10 +752,6 @@ def prepare_inputs(self, times=None, irradiance=None, weather=None):
"Please use the weather parameter to pass a DataFrame " +
"with irradiance (ghi, dni, dhi), wind speed and " +
"temp_air.\n")
if irradiance is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines from "# The following part could be removed together with the irradiance" through "# **** End ****" should also be deleted.

@wholmgren wholmgren changed the title Addressed Issue #488 remove irradiance parameter from ModelChain.run_model and ModelChain.prepare_inputs Jun 23, 2018
@wholmgren wholmgren added this to the 0.6.0 milestone Jun 23, 2018
@wholmgren wholmgren added the api label Jun 23, 2018
@wholmgren
Copy link
Member

Thanks @alamathe1! I'll merge this in a few days if there are no other comments. The test failures are unrelated.

@alamathe1
Copy link
Contributor Author

@wholmgren Alright thanks!

@wholmgren
Copy link
Member

Thanks again @alamathe1!

@wholmgren wholmgren merged commit fe5d90d into pvlib:master Jun 26, 2018
@alamathe1 alamathe1 deleted the alamathe branch June 26, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants