-
Notifications
You must be signed in to change notification settings - Fork 1.1k
remove irradiance parameter from ModelChain.run_model and ModelChain.prepare_inputs #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a note to the api section of docs/sphinx/source/whatsnew/v0.6.0.rst as well as your name or username
pvlib/modelchain.py
Outdated
@@ -754,10 +752,6 @@ def prepare_inputs(self, times=None, irradiance=None, weather=None): | |||
"Please use the weather parameter to pass a DataFrame " + | |||
"with irradiance (ghi, dni, dhi), wind speed and " + | |||
"temp_air.\n") | |||
if irradiance is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lines from "# The following part could be removed together with the irradiance" through "# **** End ****" should also be deleted.
Thanks @alamathe1! I'll merge this in a few days if there are no other comments. The test failures are unrelated. |
@wholmgren Alright thanks! |
Thanks again @alamathe1! |
pvlib python pull request guidelines
Thank you for your contribution to pvlib python!
You may submit a pull request with your code at any stage of completion, however, before the code can be merged the following items must be addressed:
git diff upstream/master -u -- "*.py" | flake8 --diff
and/or landscape.io linting service.docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
file for all changes.Please don't hesitate to ask for help if you're unsure of how to accomplish any of the above. You may delete all of these instructions except for the list above.
Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):