-
Notifications
You must be signed in to change notification settings - Fork 1.1k
clean up 0.8 whatsnew, other minor doc issues #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A handful of nits
Co-authored-by: Kevin Anderson <[email protected]>
@cwhanse @mikofski @kanderso-nrel any final edits? I plan to tag 0.8.0 once this is merged. Rendered whats new: https://pvlib-python--1054.org.readthedocs.build/en/1054/whatsnew.html |
This bullet in enhancements could be formatted:
I think the arguments should have double backticks and the classes should be linked to module index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Will!
Only edit I saw, @mikofski noted. |
I should have listened to @kanderso-nrel when he caught that in the PR review. If that's a rule it should be in the Contributing/Documentation section. |
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).Please let me know if I've missed any contributors to issue/PR discussions that were closed in this release.