Skip to content

clean up 0.8 whatsnew, other minor doc issues #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 8, 2020

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Sep 7, 2020

  • Closes change whats new API section names #1009
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Please let me know if I've missed any contributors to issue/PR discussions that were closed in this release.

@wholmgren wholmgren added this to the 0.8.0 milestone Sep 7, 2020
@wholmgren wholmgren mentioned this pull request Sep 7, 2020
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A handful of nits

@wholmgren
Copy link
Member Author

@cwhanse @mikofski @kanderso-nrel any final edits? I plan to tag 0.8.0 once this is merged.

Rendered whats new: https://pvlib-python--1054.org.readthedocs.build/en/1054/whatsnew.html

@mikofski
Copy link
Member

mikofski commented Sep 8, 2020

This bullet in enhancements could be formatted:

Added racking_model, module_type, and temperature_model_parameters to PVSystem, LocalizedPVSystem, SingleAxisTracker, and LocalizedSingleAxisTracker repr methods. (GH1027)

I think the arguments should have double backticks and the classes should be linked to module index

Copy link
Member

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Will!

@cwhanse
Copy link
Member

cwhanse commented Sep 8, 2020

Only edit I saw, @mikofski noted.

@wholmgren
Copy link
Member Author

I should have listened to @kanderso-nrel when he caught that in the PR review. If that's a rule it should be in the Contributing/Documentation section.

@wholmgren wholmgren merged commit 72f3783 into pvlib:master Sep 8, 2020
@wholmgren wholmgren deleted the whatsnew08 branch September 8, 2020 21:33
@wholmgren wholmgren mentioned this pull request Sep 23, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change whats new API section names
4 participants