Skip to content

Update PVGIS TMY tests and files #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

AdamRJensen
Copy link
Member

  • Closes PVGIS tests are failing #2221
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The default API endpoint for PVGIS has changed from 5.1 to 5.2, which has caused the tests for pvgis.iotools.get_pvgis_tmy. The *_pvgis_hourly tests are not affected as these specify the specific endpoint (5.2).

@AdamRJensen AdamRJensen added io testing remote-data triggers --remote-data pytests labels Sep 25, 2024
@AdamRJensen AdamRJensen marked this pull request as ready for review September 25, 2024 15:52
@kandersolar kandersolar added this to the v0.11.1 milestone Sep 25, 2024
@kandersolar kandersolar mentioned this pull request Sep 25, 2024
11 tasks
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, although I didn't inspect the contents of any data files.

@kandersolar kandersolar merged commit c6ba6ed into pvlib:main Sep 26, 2024
26 checks passed
@kandersolar
Copy link
Member

Thanks @AdamRJensen :)

@AdamRJensen AdamRJensen deleted the update_pvgis_3_2_tests branch September 29, 2024 18:32
@kandersolar kandersolar mentioned this pull request Nov 25, 2024
6 tasks
@kandersolar kandersolar mentioned this pull request Apr 10, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PVGIS tests are failing
2 participants