Skip to content

Update pvgis test data files #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

kandersolar
Copy link
Member

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

PVGIS TMY data has apparently been updated again, causing remote-data tests to fail. https://github.com/pvlib/pvlib-python/actions/runs/14386680023/job/40343717051

This is the latest in a sequence of changes needed to keep the PVGIS tests passing. Perhaps we should rethink how we test these functions. Previous PRs:

@kandersolar kandersolar added io remote-data triggers --remote-data pytests labels Apr 10, 2025
@kandersolar kandersolar added this to the v0.12.1 milestone Apr 10, 2025
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's not optimal. Though at the same time, some of the changes to PVGIS in the past has required that we modify our functions, which we wouldn't have discovered if they didn't fail.

It's a shame that PVGIS isn't better about consistency though.

@kandersolar kandersolar merged commit 4707664 into pvlib:main Apr 11, 2025
42 checks passed
@kandersolar kandersolar deleted the pvgis-tests branch April 11, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants