Skip to content

Fix get_pvgis_tmy for outputformat='csv' #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2025

Conversation

kandersolar
Copy link
Member

  • Closes Error for get_pvgis_tmy with outputformat='csv'  #2344
  • I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the v0.11.3 milestone Feb 21, 2025
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Feb 21, 2025
@kandersolar kandersolar added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Feb 21, 2025
@kandersolar kandersolar requested a review from AdamRJensen March 4, 2025 20:23
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I do still think we should remove the outputformat parameter later though.

@kandersolar kandersolar merged commit 40a213b into pvlib:main Mar 14, 2025
24 of 25 checks passed
@kandersolar kandersolar deleted the pvgis-tmy-csv branch March 14, 2025 15:15
@kandersolar kandersolar modified the milestones: v0.11.3, v0.12.0 Mar 14, 2025
@kandersolar kandersolar mentioned this pull request Apr 10, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error for get_pvgis_tmy with outputformat='csv'
2 participants