Improve precision of v_from_i for large arguments#260
Closed
cwhanse wants to merge 2 commits intopvlib:masterfrom
cwhanse:master
Closed
Improve precision of v_from_i for large arguments#260cwhanse wants to merge 2 commits intopvlib:masterfrom cwhanse:master
cwhanse wants to merge 2 commits intopvlib:masterfrom
cwhanse:master
Conversation
Number of iterations of Newton method should increase with the order of the argument, to maintain precision. Not expected to have a significant effect on most calculated IV curves.
Member
|
Looks like the tests are failing for two reasons: 1. Finally, please add a note and your name to the docs/sphinx/source/whatsnew/v0.4.2.txt file too. |
Closed
Member
Author
|
Closing this to submit a clean set of files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Number of iterations of Newton method should increase with the order of
the argument, to maintain precision. Not expected to have a significant
effect on most calculated IV curves.