Skip to content

Improve precision of v_from_i for large arguments #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve precision of v_from_i for large arguments #260

wants to merge 2 commits into from

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Nov 12, 2016

Number of iterations of Newton method should increase with the order of
the argument, to maintain precision. Not expected to have a significant
effect on most calculated IV curves.

Number of iterations of Newton method should increase with the order of
the argument, to maintain precision.  Not expected to have a significant
effect on most calculated IV curves.
@wholmgren
Copy link
Member

Looks like the tests are failing for two reasons: 1. order needs to be a scalar, and 2. order needs to be an integer. Something like this might work

order = np.floor(np.max(np.log10(w))).astype('int')

Finally, please add a note and your name to the docs/sphinx/source/whatsnew/v0.4.2.txt file too.

@wholmgren wholmgren added this to the 0.4.2 milestone Nov 14, 2016
@mikofski mikofski mentioned this pull request Nov 17, 2016
Closed
@cwhanse
Copy link
Member Author

cwhanse commented Nov 22, 2016

Closing this to submit a clean set of files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants