Skip to content

Improve convergence of lambertw for very large arguments #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve convergence of lambertw for very large arguments #298

wants to merge 2 commits into from

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Jan 17, 2017

No description provided.

@cwhanse
Copy link
Member Author

cwhanse commented Jan 17, 2017

The test failures don't look to be caused by my one edit which changes range(0,3) to range(9) in pvsystem.

@wholmgren
Copy link
Member

Is it easy to add a test that requires this change in order to pass? test_pvsystem.py has the following function that you could copy/paste, rename, and then update with your parameters:

@requires_scipy
def test_v_from_i_bigger():
    # 1000 W/m^2 on a Canadian Solar 220M with 20 C ambient temp
    # github issue 225
    output = pvsystem.v_from_i(190, 1.065, 2.89, 0, 7.05196029e-08, 10.491262)
    assert_allclose(54.303958833791455, output, atol=1e-5)

For reference, this is a continuation of #268, #266, #260.

@wholmgren wholmgren added this to the 0.4.5 milestone Feb 15, 2017
@wholmgren wholmgren modified the milestones: 0.4.6, 0.4.5 May 30, 2017
@wholmgren wholmgren removed this from the 0.4.6 milestone Aug 8, 2017
@cwhanse
Copy link
Member Author

cwhanse commented Aug 12, 2017

I haven't been able to reproduce the failure, so let's close this pull request. We can always re-open if we find the failure conditions again.

@cwhanse cwhanse closed this Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants