Improve convergence of lambertw for very large arguments#298
Closed
cwhanse wants to merge 2 commits intopvlib:masterfrom
cwhanse:master
Closed
Improve convergence of lambertw for very large arguments#298cwhanse wants to merge 2 commits intopvlib:masterfrom cwhanse:master
cwhanse wants to merge 2 commits intopvlib:masterfrom
cwhanse:master
Conversation
Member
Author
|
The test failures don't look to be caused by my one edit which changes range(0,3) to range(9) in pvsystem. |
Member
|
Is it easy to add a test that requires this change in order to pass? test_pvsystem.py has the following function that you could copy/paste, rename, and then update with your parameters: @requires_scipy
def test_v_from_i_bigger():
# 1000 W/m^2 on a Canadian Solar 220M with 20 C ambient temp
# github issue 225
output = pvsystem.v_from_i(190, 1.065, 2.89, 0, 7.05196029e-08, 10.491262)
assert_allclose(54.303958833791455, output, atol=1e-5) |
This reverts commit d83d77d.
Member
Author
|
I haven't been able to reproduce the failure, so let's close this pull request. We can always re-open if we find the failure conditions again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.