refactor: replace .get_type with type::handle_of #2492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
refactor/handle_of
branch
from
245157f to
b4560fe
Compare
bstaletic
approved these changes
Sep 16, 2020
|
@YannickJadoul 3.9 macOS segfault example. :/ |
henryiii
commented
Sep 16, 2020
YannickJadoul
approved these changes
Sep 16, 2020
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Sep 17, 2020
This now tests the old form too, and fixes the bug introduced.
Merged
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Sep 17, 2020
This now tests the old form too, and fixes the bug introduced.
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Sep 17, 2020
This now tests the old form too, and fixes the bug introduced.
henryiii
added a commit
that referenced
this pull request
Sep 17, 2020
This now tests the old form too, and fixes the bug introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2388, followup to #2364.
Added a
handle_of, which returns a handle instead, so as not to introduce a lot of reference counting where we didn't have it before.