fix/typebug #2497
Merged
fix/typebug #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
henryiii
commented
Sep 17, 2020
henryiii
commented
- fix: type bug intruduced in refactor: replace .get_type with type::handle_of #2492
- tests: the condition was too look on xfail
henryiii
force-pushed
the
fix/typebug
branch
from
1f4729d to
add261b
Compare
This now tests the old form too, and fixes the bug introduced.
henryiii
force-pushed
the
fix/typebug
branch
from
add261b to
1927834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.