ci: use fixed action #2791
Merged
ci: use fixed action #2791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, that's amazingly fast! |
|
Failing tests are #2774. Let's get this in! |
| - name: Setup CMake 3.18 | ||
| uses: jwlawson/[email protected] | ||
| with: | ||
| cmake-version: 3.18 |
There was a problem hiding this comment.
😳 Whoops, bit late, after I just merged, but this is 3.18.
Was there a reason for it to be 3.18? I guess not, because you also removed the name change, @henryiii?
There was a problem hiding this comment.
If it's passing, I think it's okay, since we test each version elsewhere. But I didn't see that it was 3.18, I thought it was an inconsistently named 3.19.
There was a problem hiding this comment.
There might have been a bug in an early version of 3.19, but hopefully if so, it is fixed.
There was a problem hiding this comment.
Tests are passing, so we should be fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out jwlawson/actions-setup-cmake#18. Followup to #2790.