Skip to content

ci: use fixed action #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021
Merged

ci: use fixed action #2791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ jobs:
run: echo "BOOST_ROOT=$BOOST_ROOT_1_72_0" >> $GITHUB_ENV

- name: Update CMake
uses: jwlawson/[email protected]
with:
cmake-version: 3.19.2
uses: jwlawson/[email protected]

- name: Cache wheels
if: runner.os == 'macOS'
Expand Down Expand Up @@ -363,10 +361,8 @@ jobs:
- name: Update pip
run: python3 -m pip install --upgrade pip

- name: Setup CMake 3.18
uses: jwlawson/[email protected]
with:
cmake-version: 3.18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳 Whoops, bit late, after I just merged, but this is 3.18.

Was there a reason for it to be 3.18? I guess not, because you also removed the name change, @henryiii?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's passing, I think it's okay, since we test each version elsewhere. But I didn't see that it was 3.18, I thought it was an inconsistently named 3.19.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might have been a bug in an early version of 3.19, but hopefully if so, it is fixed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing, so we should be fine?

- name: Update CMake
uses: jwlawson/[email protected]

- name: Configure
shell: bash
Expand Down Expand Up @@ -551,9 +547,7 @@ jobs:
architecture: x86

- name: Update CMake
uses: jwlawson/[email protected]
with:
cmake-version: 3.19.2
uses: jwlawson/[email protected]

- name: Prepare MSVC
uses: ilammy/msvc-dev-cmd@v1
Expand Down Expand Up @@ -599,9 +593,7 @@ jobs:
python-version: ${{ matrix.python }}

- name: Update CMake
uses: jwlawson/[email protected]
with:
cmake-version: 3.19.2
uses: jwlawson/[email protected]

- name: Prepare MSVC
uses: ilammy/msvc-dev-cmd@v1
Expand Down Expand Up @@ -655,9 +647,7 @@ jobs:
python-version: ${{ matrix.python }}

- name: Update CMake
uses: jwlawson/[email protected]
with:
cmake-version: 3.19.2
uses: jwlawson/[email protected]

- name: Prepare env
run: python -m pip install -r tests/requirements.txt --prefer-binary
Expand Down