FIX strike prices > 1k #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fails with Python 2.6. Any idea ? |
|
I took a look, but I haven't run into that one before. This kind of thing is why I filed #160. |
|
Are the tests passing for Python 3.x and 2.7? The code change looks right to me. |
|
Change is minimal... maybe I can remove this test. I know it's an odd way to fix a test ;-) |
|
Looks good - can you squash? |
femtotrader
force-pushed
the
issue168_strike_prices_thousands
branch
from
cc96ccf to
b7a41fd
Compare
|
Squashed |
femtotrader
added a commit
that referenced
this pull request
Feb 25, 2016
…ands FIX strike prices > 1k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #168