Skip to content

FIX strike prices > 1k #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas_datareader/tests/test_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
assert_produces_warning = None

import pandas.util.testing as tm

from numpy.testing import assert_array_equal

import pandas_datareader.data as web
Expand Down Expand Up @@ -483,6 +484,7 @@ def test_month_year(self):
raise nose.SkipTest(e)

self.assertTrue(len(data) > 1)
self.assertEqual(data.index.levels[0].dtype, 'float64') # GH168

def test_empty_table(self):
# GH22
Expand Down
2 changes: 1 addition & 1 deletion pandas_datareader/yahoo/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def _parse_options_data(table):
rows = table.findall('tbody/tr')
data = [_unpack(r) for r in rows]
if len(data) > 0:
return TextParser(data, names=header).get_chunk()
return TextParser(data, names=header, thousands=',').get_chunk()
else: # Empty table
return DataFrame(columns=header)

Expand Down