Skip to content

Rename attributes to attrs? #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoyer opened this issue Apr 17, 2014 · 0 comments · Fixed by #107
Closed

Rename attributes to attrs? #103

shoyer opened this issue Apr 17, 2014 · 0 comments · Fixed by #107
Labels
design question

Comments

@shoyer
Copy link
Member

shoyer commented Apr 17, 2014

I noticed that pytables, h5py and blz all use the shorter attrs instead of attributes as the name of the attributes mapping. What do you guys think about switching over?
@shoyer shoyer closed this as completed in 17149dd Apr 21, 2014
shoyer added a commit that referenced this issue Apr 27, 2014
@shoyer
Deprecated 'attributes' in favor of 'attrs'
1adb6e3 
Also:
1. Don't try to preserve attributes under mathematical operations.
2. Finish up some cleanup related to "equals" and "identical" for testing.

Fixes #103 and #104.
shoyer added a commit that referenced this issue Apr 27, 2014
@shoyer
Deprecated 'attributes' in favor of 'attrs'
5c056c6 
Also:
1. Don't try to preserve attributes under mathematical operations.
2. Finish up some cleanup related to "equals" and "identical" for testing.
3. Options for how strictly to compare varaibles when merging or concatenating
   (see #25).

Fixes #103 and #104.
shoyer added a commit that referenced this issue Apr 27, 2014
@shoyer
Deprecated 'attributes' in favor of 'attrs'
23b2cdd 
Also:
1. Don't try to preserve attributes under mathematical operations.
2. Finish up some cleanup related to "equals" and "identical" for testing.
3. Options for how strictly to compare varaibles when merging or concatenating
   (see #25).

Fixes #103 and #104.
@shoyer shoyer mentioned this issue Apr 27, 2014
Merged
keewis pushed a commit to keewis/xarray that referenced this issue Jan 17, 2024
@TomNicholas @pre-commit-ci
Data structures docs (pydata#103)
133f60c 
* sketching out changes needed to integrate variables into DataTree

* fixed some other basic conflicts

* fix mypy errors

* can create basic datatree node objects again

* child-variable name collisions dectected correctly

* in-progres

* add _replace method

* updated tests to assert identical instead of check .ds is expected_ds

* refactor .ds setter to use _replace

* refactor init to use _replace

* refactor test tree to avoid init

* attempt at copy methods

* rewrote implementation of .copy method

* xfailing test for deepcopying

* pseudocode implementation of DatasetView

* Revert "pseudocode implementation of DatasetView"

This reverts commit 52ef23baaa4b6892cad2d69c61b43db831044630.

* removed duplicated implementation of copy

* reorganise API docs

* expose data_vars, coords etc. properties

* try except with calculate_dimensions private import

* add keys/values/items methods

* don't use has_data when .variables would do

* explanation of basic properties

* add data structures page to index

* revert adding documentation in favour of that going in a different PR

* explanation of basic properties

* add data structures page to index

* create tree node-by-node

* create tree from dict

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* dict-like interface

* correct deepcopy tests

* use .data_vars in copy tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* black

* whatsnew

* data contents

* dictionary-like access

* TODOs

* test assigning int

* allow assigning coercible values

* simplify example using pydata#115

* add note about fully qualified names

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecated 'attributes' in favor of 'attrs' pydata/xarray
1 participant
@shoyer