Skip to content

Simpler handling of attributes under mathematical operations? #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoyer opened this issue Apr 21, 2014 · 0 comments
Closed

Simpler handling of attributes under mathematical operations? #104

shoyer opened this issue Apr 21, 2014 · 0 comments
Labels
design question

Comments

@shoyer
Copy link
Member

shoyer commented Apr 21, 2014

I'm thinking now that instead of trying to preserve attributes on variables, it would be preferable to drop all attributes (not just conflicting ones) when doing mathematical operations. This would keep things a bit simpler/easier to understand. Thoughts?
shoyer added a commit that referenced this issue Apr 27, 2014
@shoyer
Deprecated 'attributes' in favor of 'attrs'
1adb6e3 
Also:
1. Don't try to preserve attributes under mathematical operations.
2. Finish up some cleanup related to "equals" and "identical" for testing.

Fixes #103 and #104.
shoyer added a commit that referenced this issue Apr 27, 2014
@shoyer
Deprecated 'attributes' in favor of 'attrs'
5c056c6 
Also:
1. Don't try to preserve attributes under mathematical operations.
2. Finish up some cleanup related to "equals" and "identical" for testing.
3. Options for how strictly to compare varaibles when merging or concatenating
   (see #25).

Fixes #103 and #104.
shoyer added a commit that referenced this issue Apr 27, 2014
@shoyer
Deprecated 'attributes' in favor of 'attrs'
23b2cdd 
Also:
1. Don't try to preserve attributes under mathematical operations.
2. Finish up some cleanup related to "equals" and "identical" for testing.
3. Options for how strictly to compare varaibles when merging or concatenating
   (see #25).

Fixes #103 and #104.
@shoyer shoyer mentioned this issue Apr 27, 2014
Merged
@shoyer shoyer closed this as completed Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shoyer