Skip to content

Use "XIndex" instead of "Index"? #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoyer opened this issue Jul 2, 2014 · 1 comment · Fixed by #181
Closed

Use "XIndex" instead of "Index"? #178

shoyer opened this issue Jul 2, 2014 · 1 comment · Fixed by #181
Labels
API design
Milestone
0.2

Comments

@shoyer
Copy link
Member

shoyer commented Jul 2, 2014

In #161, I renamed xray.Coordinate to xray.Index.

To better distinguish xray's Index from pandas, let's call it XIndex instead.
@shoyer shoyer added the API label Jul 2, 2014
@shoyer shoyer added this to the 0.2 milestone Jul 2, 2014
shoyer added a commit to shoyer/xarray that referenced this issue Jul 6, 2014
@shoyer
Rename Index (formerly Coordinate) to XIndex
acee12f 
Fixes pydata#178
@shoyer shoyer mentioned this issue Jul 6, 2014
Closed
@shoyer
Copy link
Member Author

shoyer commented Jul 10, 2014

I guess I've come full circle on this one.

After trying it for a bit, I realized that having xray.Index as a subtly distinct variant of pandas.Index was a bad idea. Hence this issue.

But the name XIndex is awkward, new vocabulary. I don't think it's any better (for pandas users) than Coordinate.

So now I think it's like to switch back to Coordinate.

(at least I didn't release a version with that temporary name change!)

shoyer added a commit to shoyer/xarray that referenced this issue Jul 10, 2014
@shoyer
Rename xray.Index back to Coordinate
5d255e1 
Related pydata#142, pydata#161

Fixes pydata#178
@shoyer shoyer mentioned this issue Jul 10, 2014
Merged
@shoyer shoyer changed the title Use "XIndex" instead of "Index" Use "XIndex" instead of "Index"? Jul 14, 2014
keewis pushed a commit to keewis/xarray that referenced this issue Jan 17, 2024
@TomNicholas @pre-commit-ci
Fix name permanence behaviour in update method (pydata#178)
4eb70a6 
* test for name permanence in update

* ensure node is copied on update

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* black

* whatsnew

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API design
Projects
None yet
Milestone
0.2
1 participant
@shoyer